Migrate ValueTypeMap & MemoryDescriptor#2232
Migrate ValueTypeMap & MemoryDescriptor#2232github-actions[bot] merged 5 commits intomicrosoft:mainfrom
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/patches/values.kdl
Outdated
| @@ -0,0 +1,9 @@ | |||
| dictionary ValueTypeMap legacyNamespace="WebAssembly" exposed="Window Worker Worklet" { | |||
There was a problem hiding this comment.
The existing webassembly.kdl seems like the best place to put this.
src/build/helpers.ts
Outdated
| "undefined", | ||
| "void", | ||
| "bigint", | ||
| "never", |
There was a problem hiding this comment.
never is not an IDL type, please use overrideType for that. bigint is, though.
inputfiles/patches/values.kdl
Outdated
| @@ -0,0 +1,9 @@ | |||
| dictionary ValueTypeMap legacyNamespace="WebAssembly" exposed="Window Worker Worklet" { | |||
| member anyfunc required=#true type="Function" | |||
There was a problem hiding this comment.
No need to quote types nor legacyNamespace.
|
Hello @saschanaz |
Bashamega
changed the title
src/build/patches.ts
Outdated
| return { | ||
| name, | ||
| members: { member }, | ||
| ...optionalMember("extends", "string", child.properties?.extends), |
There was a problem hiding this comment.
This line can be skipped for now, as we are not using "extends" here. You might have intended to do "exposed" but...
inputfiles/patches/webassembly.kdl
Outdated
| enum TableKind legacyNamespace=WebAssembly | ||
| enum AddressType legacyNamespace=WebAssembly | ||
|
|
||
| dictionary ValueTypeMap legacyNamespace=WebAssembly exposed="Window Worker Worklet" { |
There was a problem hiding this comment.
While we are at it, let's remove exposed here. Dictionaries do not need it and I missed it in #963.
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
#2053
I added support for
legacyNamespace,overrideType, andextendsfor the dictionory parser.