Conversation
| - run: npm run build-all | ||
| cache: 'pnpm' | ||
|
|
||
| - run: pnpm install |
There was a problem hiding this comment.
This awkwardly already runs build-all.
I'd prefer it didn't, but our docs would need to be updated if that changes.
No, I want that to stay out of everyone's way.
I don't think it makes much of a difference, right? If we did this, would it work out of the box for anyone with Node 18+? Or would people have to run a command?
I can just run that manually I think. It doesn't need to be a script. |
Do you want me to convert that to
People still have to run
Right now there's no script or anything; you can technically leave the old specifiers in but pnpm won't help you update them everywhere as far as I know. |
| npm run build | ||
| git clone https://github.com/microsoft/TypeChat | ||
| cd TypeChat | ||
| pnpm install |
There was a problem hiding this comment.
Not everyone knows pnpm, I'd recommend adding pnpm install instructions (it could seem like a typo). https://pnpm.io/cli/install
Fixes #81
Outstanding questions:
build-allonprepare?sitebe a part of the monorepo?build-allbuild the site?changesets.Theoretically I can attempt to do this via plain
npmthough @DanielRosenwasser had problems with it hence asking me to send this PR for real.