Feature/GitHub codespaces organization#416
Feature/GitHub codespaces organization#416vercellone wants to merge 97 commits intomicrosoft:masterfrom
Conversation
- Stop-GitHubCodespace - Wait-GitHubCodespaceAction
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
not howard Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
|
Please review, @HowardWolosky. |
|
TypeName assertions resolved. Any other feedback, @HowardWolosky? |
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for those updates. Looks just about there. I'll kick off a validation run to see if I missed anything else.
| GitHub Apps must have write access to the codespaces_lifecycle_admin repository permission to use this endpoint. | ||
| #> | ||
| [CmdletBinding( | ||
| DefaultParameterSetName = 'AuthenticatedUser', |
There was a problem hiding this comment.
My preference here would be to avoid ambiguous code. As a code reader, it took too much time for me to look at what's here and parse out what might be happening. A comment could probably address that, but even better would simply be having the code be declarative on intention. In this specific scenario, this could be resolved by augmenting the $CodespaceName declaration to be part of two different parametersets, and then having the default one be one that's actually defined.
[Parameter(
Mandatory,
ValueFromPipeline,
ValueFromPipelineByPropertyName,
ParameterSetName = 'Organization')]
[Parameter(
Mandatory,
ValueFromPipeline,
ValueFromPipelineByPropertyName,
ParameterSetName = 'AuthenticatedUser')]
[string] $CodespaceName,|
/azp run PowerShellForGitHub-CI |
$null = Invoke-GHRestMethod @params Co-authored-by: Howard Wolosky <HowardWolosky@users.noreply.github.com>
…erset for readability
|
Please review again, @HowardWolosky. |
|
@HowardWolosky 8 months!? Your resource management policy seems a bit biased. |
|
Am I missing something here? How can I move this PR forward? Should I submit a new PR? |
Description
Add outstanding support for Codespaces organizations and Codespaces machines.
Issues Fixed
References
Codespaces/organizations
Codespaces/machines
Checklist