Update BasicCallStack Test Frame lines for CppVsDbg#1541
Merged
WardenGnaw merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
This PR updates checkCallStack line 81 to 80 which matches what the cpp file has. Same with callback func
Member
Do you know if this is still correct? I would have thought it would be the same now Refers to: test/CppTests/Tests/ExpressionTests.cs:526 in b7fa847. [](commit_id = b7fa847, deletion_comment = False) |
gregg-miskelly
approved these changes
Jan 27, 2026
gregg-miskelly
approved these changes
Jan 28, 2026
WardenGnaw
added a commit
that referenced
this pull request
Feb 3, 2026
* Disable SBOM for non-folder publish and fix SymbolUpload Warning (#1540) Disable SBOM for non-folder publish and other warnings This PR disables SBOM for non-folder publishes because the build will get a warning saying: "BuildDropPath '<FILE PATH>' must be a directory, not a file" Disabling SBOM checks where we know we are only publishing a file. Changing ExpirationInDays to be 5475 * Update BasicCallStack Test Frame lines for CppVsDbg (#1541) * Update BasicCallStack Test Frame lines This PR updates checkCallStack line 81 to 80 which matches what the cpp file has. Same with callback func * x86 and x64 should be the same now * Refactor DebuggerTesting pipeline for 1ES Compliance (#1542) * Refactor DebuggerTesting pipeline for 1ES Compliance * Add comment * DebuggerTesting-Release updates (#1543) Use Test Sign for Testing packages * Remove branch trigger and CI check for releases (#1544) * Remove branch trigger and CI check for releases * Trigger: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the expected stack frame line numbers in the
GenerateFramesListmethod within theExpressionTests.cstest file. The changes ensure that the test expectations match the actual source code locations.Merged the MSVC x86 and x64 branches since that has been fixed with the latest toolsets.