save and load max_record_size and leaf_page_size for bftrees#724
Open
save and load max_record_size and leaf_page_size for bftrees#724
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the BfTree save/load functionality by adding support for persisting and restoring the max_record_size and leaf_page_size configuration parameters. This builds upon previously implemented save/load infrastructure and leverages new getter functions available in bftree version 0.4.7.
Changes:
- Introduced
BfTreeParamsstruct to encapsulate BfTree configuration parameters (bytes, max_record_size, leaf_page_size) - Updated
SavedParamsandQuantParamsto useBfTreeParamsinstead of simpleusizevalues - Modified load functions to restore BfTree configurations with saved max_record_size and leaf_page_size values
- Updated tests to demonstrate save/load of BfTree configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 89.01% 90.31% +1.30%
==========================================
Files 428 428
Lines 78151 78294 +143
==========================================
+ Hits 69566 70715 +1149
+ Misses 8585 7579 -1006 🚀 New features to boost your workflow:
|
metajack
approved these changes
Feb 5, 2026
hildebrandmw
reviewed
Feb 5, 2026
diskann-providers/src/model/graph/provider/async_/bf_tree/provider.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR, which builds upon an internal PR where we started implementing save/load functionality for bftrees. Since we recently bumped up bftree version to 0.4.7, which implements getter functions for max_record_size and leaf_page_size, we can save and load these variables when saving and load bftrees. This is necessary to do because we might need to increase max_record_size and leaf_page_size if the dimensionality of the vectors is too large