Open
Conversation
The code passes `mypy` check. Python 2 support has been dropped, as Python 2 has reached end of life. Added type hints. Added conditions to ensure clear error description when `self._srv_handler` connection has not been opened but read. Added conditions to avoid crashes when `split()` result is too short and can not be unpacked. The package version increased by 0.0.1.
Owner
|
Apologies for the slow follow-up and thanks for the PR. Will try to find some time soon to review/test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code passes
mypycheck.Python 2 support has been dropped, as Python 2 has reached end of life.
Added type hints.
Added conditions to ensure clear error description when
self._srv_handlerconnection has not been opened but read.Added conditions to avoid crashes when
split()result is too short and can not be unpacked.The package version increased by 0.0.1.