Open
Conversation
majst01
reviewed
Feb 3, 2026
Comment on lines
+172
to
+197
| message SwitchNicWithMachine { | ||
| // Nic is the switch nic the machine is connected to. | ||
| SwitchNic nic = 1; | ||
| // Uuid of the machine. | ||
| string uuid = 2; | ||
| // Size of the machine. | ||
| string size = 3; | ||
| // AllocationHostname if machine is allocated. | ||
| string allocation_hostname = 4; | ||
| // VpnConnected indicated whether the machine is connected to a VPN. | ||
| bool vpn_connected = 5; | ||
| // FruProductSerial of the machine. | ||
| string fru_product_serial = 6; | ||
| // FruChassisPartSerial of the machine. | ||
| string fru_chassis_part_serial = 7; | ||
| // Liveliness of the machine. | ||
| metalstack.api.v2.MachineLiveliness liveliness = 8; | ||
| // State of the machine. | ||
| metalstack.api.v2.MachineState state = 9; | ||
| // FailedReclaim is true if the machine failed to return to the waiting machines pool after deletion. | ||
| bool failed_reclaim = 10; | ||
| // Crashloop is true if there was an unexpected event in the provisioning cycle. | ||
| bool crashloop = 11; | ||
| // LastErrorEventTime in case some error happened in the past. | ||
| google.protobuf.Timestamp last_error_event_time = 12; | ||
| } |
Contributor
There was a problem hiding this comment.
I am unsure, feels ugly, maybe we find another way to provide whats required, but does not randomly put data together which also require to fetch a lot of entities in the backend.
Contributor
Author
There was a problem hiding this comment.
I don't like it either. In the metal-api, the SwitchIPMIResponse contains Machine and IPMI, which would be BMC in this case. But the message would be huge while we only need a tiny subset of the fields. I don't have a good idea how to solve this.
Contributor
Author
There was a problem hiding this comment.
In any case we will have to fetch those entities, no matter what the message looks like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
None