-
Notifications
You must be signed in to change notification settings - Fork 19
[MOO-2205] Update RN version to 0.78.2 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...rator-widget/generators/app/templates/packages/__tests__/outputs/package_native.json-ts.json
Outdated
Show resolved
Hide resolved
LEGIO-SEXTA-FERRATA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review is done. 👍
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-native": "~0.77.3" | ||
| "react-native": "0.78.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add the tilde (~) for the new version as well.
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-native": "~0.77.3", | ||
| "react-native": "0.78.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing with the package.json, we can prefix the new version with a tilde.
| - We migrated to pnpm as our package manager. Users of the widgets tools should be able to continue using their package manager of choice. | ||
|
|
||
| - We updated React Native to version 0.77.3 to align with the Native Widgets project requirements. | ||
| - We updated React Native to version 0.78.2 to align with the Native Widgets project requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of changing the existing changelog entry, we should add a new one to the unreleased part.
| ### Changed | ||
|
|
||
| - We upgraded React Native to version 0.77.3 for generated widgets. | ||
| - We upgraded React Native to version 0.78.2 for generated widgets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing with the CHANGELOG.md for PWT, we should add a new entry instead of changing an existing one.
| // Auto-accept in non-interactive environments (CI, automated tests) | ||
| if (!process.stdin.isTTY || process.env.CI || process.env.NO_INPUT) { | ||
| console.log(yellow(question) + "Y (auto-accepted in non-interactive mode)"); | ||
| return "y"; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this part?
✅ Web TypeScript (8.0, 8.6, 8.9, latest) - full & empty
✅ Web JavaScript (8.7, latest) - full & empty
✅ Native TypeScript (8.6, 8.9, latest) - full & empty
✅ Native JavaScript (latest) - full & empty
Every test passed including:
Widget generation
Build commands
Release commands
Dependencies files
npm start (watch mode)
Native dependency management