Skip to content

Conversation

@NikolaSimsic
Copy link

  • Updated RN to 0.78.2 to match the one used in Native Widgets.
  • Tested with automated generating different variations of widgets
  • All 14 widget configurations tested successfully:

✅ Web TypeScript (8.0, 8.6, 8.9, latest) - full & empty
✅ Web JavaScript (8.7, latest) - full & empty
✅ Native TypeScript (8.6, 8.9, latest) - full & empty
✅ Native JavaScript (latest) - full & empty

  • Every test passed including:

  • Widget generation

  • Build commands

  • Release commands

  • Dependencies files

  • npm start (watch mode)

  • Native dependency management

Copy link
Contributor

@LEGIO-SEXTA-FERRATA LEGIO-SEXTA-FERRATA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review is done. 👍

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-native": "~0.77.3"
"react-native": "0.78.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the tilde (~) for the new version as well.

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-native": "~0.77.3",
"react-native": "0.78.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing with the package.json, we can prefix the new version with a tilde.

- We migrated to pnpm as our package manager. Users of the widgets tools should be able to continue using their package manager of choice.

- We updated React Native to version 0.77.3 to align with the Native Widgets project requirements.
- We updated React Native to version 0.78.2 to align with the Native Widgets project requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the existing changelog entry, we should add a new one to the unreleased part.

### Changed

- We upgraded React Native to version 0.77.3 for generated widgets.
- We upgraded React Native to version 0.78.2 for generated widgets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing with the CHANGELOG.md for PWT, we should add a new entry instead of changing an existing one.

Comment on lines +67 to +71
// Auto-accept in non-interactive environments (CI, automated tests)
if (!process.stdin.isTTY || process.env.CI || process.env.NO_INPUT) {
console.log(yellow(question) + "Y (auto-accepted in non-interactive mode)");
return "y";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants