feat: barcode-scanner-native area scanning, flash, navigation switch reset active#403
Open
summxu wants to merge 2 commits intomendix:mainfrom
Open
feat: barcode-scanner-native area scanning, flash, navigation switch reset active#403summxu wants to merge 2 commits intomendix:mainfrom
summxu wants to merge 2 commits intomendix:mainfrom
Conversation
- Implemented flashlight switch button UI and interaction logic - Integrate react-native-vector-icons library to display flashlight icons - Updated component type definitions to include new showFlashToggle properties - Implement the scanning area filtering logic to process only the QR code within the scanning mask - Add proportional conversion to support accurate filtering for devices with different resolutions - Refactor the camera component layout to add cameraWrapper and camera styles - Implement app state listening and page focus detection to ensure changes to the isActive property of the camera component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
feat: barcode-scanner-native area scanning, flash, navigation switch reset active)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR enhances the
barcode-scanner-nativewidget by adding flashlight control capabilities and improving scanning precision. It implements a masking logic to restrict scanning to a specific area and improves the camera's lifecycle management regarding app state changes.Relevant changes
Flashlight Support:
react-native-vector-iconslibrary to display flashlight icons.showFlashToggleproperty.Scanning Area & Logic:
Refactor & Optimization:
cameraWrapperandcamerastyles.isActiveproperty of the camera component are handled correctly (pausing/resuming camera).What should be covered while testing?
Extra comments (optional)
N/A