Open
Conversation
mrvcynk
force-pushed
the
fix/signature-base64-to-image
branch
from
a9794a8 to
5a9272e
Compare
saurabhchavan1711
force-pushed
the
fix/signature-base64-to-image
branch
from
5a9272e to
2f23162
Compare
NikolaSimsic
previously approved these changes
Feb 2, 2026
MxKevinBeqo
approved these changes
Feb 4, 2026
| }); | ||
| } catch (error) { | ||
| const errorMessage = error instanceof Error ? error.message : String(error); | ||
| throw new Error(`Failed to decode base64 to image: ${errorMessage}`); |
Contributor
There was a problem hiding this comment.
Noting how we handle errors on other widgets, I would consider instead of re-throwing the error here, to log it and reject the Promise with a false value (keeping consistent the return value of the function).
Might even log it and use the Alert.alert(....) to show a native message on the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the base64decodeTo Image function synchronization issue .