feat/web view native request method headers#224
Open
wilcomx wants to merge 2 commits intomendix:mainfrom
Open
Conversation
UrazAkgultan
approved these changes
Jan 21, 2025
Collaborator
|
Looks good to me 👍 Thank you for your contribution. |
NikolaSimsic
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
What is the purpose of this PR?
This PR request adds GET (default) and POST (with optional body) method verb selection and header pass-through to the request url of the native WebView. Since url's are limited in lenght, so is the amount of additional data to pass along the request through query parameters. For example JWT's or other authentication and authorization information.
Relevant changes
This feature has added three configuration items to the advanced section of the WebView widget configuration:
headerNameandheaderValueattributes.All changes are backwards compitable and won't break the configurations of the previous version of the widget. On Android headers are only passed through GET requests. This is mentioned in the header description.
What should be covered while testing?
6 scenario's have been test on both Android and iOS:
Extra comments
Unit tests included and code coverage maintained. Applied formatting and lint.