fix(image-native): click enlarged to close#142
Open
Andries-Smit wants to merge 1 commit intomendix:mainfrom
Open
fix(image-native): click enlarged to close#142Andries-Smit wants to merge 1 commit intomendix:mainfrom
Andries-Smit wants to merge 1 commit intomendix:mainfrom
Conversation
Andries-Smit
force-pushed
the
fix/image-close-enlarged
branch
from
bfc387e to
6664aa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the “On click type” is set to ‘Enlarge’ the image will be enlarged when clicked on, as expected.
To close the modal, click on the backdrop; however, the backdrop could be very small on images in the same ratio as the screen, making it nearly impossible to close the enlargement.
Expected behaviour: When clicking on the enlarged image, it will close, too.
Fixes support ticket https://support.mendix.com/hc/en-us/requests/220159