Fix unsafe cast in InvokeInstruction analysis#5
Fix unsafe cast in InvokeInstruction analysis#5google-labs-jules[bot] wants to merge 2 commits intomasterfrom
Conversation
The static analyzer previously assumed that the reference type of an InvokeInstruction was always an ObjectType. However, it can also be an ArrayType (e.g., when calling clone() on an array). This caused a ClassCastException. This change adds a check to ensure the reference type is an ObjectType before casting. If it is not (e.g., it is an ArrayType), the instruction is treated as un-analyzable, which is consistent with how other un-analyzable methods are handled.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The static analyzer previously assumed that the reference type of an InvokeInstruction was always an ObjectType. However, it can also be an ArrayType (e.g., when calling clone() on an array). This caused a ClassCastException. This change adds a check to ensure the reference type is an ObjectType before casting. If it is not (e.g., it is an ArrayType), the instruction is treated as un-analyzable, which is consistent with how other un-analyzable methods are handled. A new test case `src/test/test24.java` has been added to cover this scenario.
Handle non-ObjectType in InvokeInstruction analysis to prevent ClassCastException.
PR created automatically by Jules for task 12161063934547584290 started by @mellon85