Add Flagging.with_flag(reason), as per README#23
Open
dgilperez wants to merge 12 commits intomedihack:masterfrom
Open
Add Flagging.with_flag(reason), as per README#23dgilperez wants to merge 12 commits intomedihack:masterfrom
dgilperez wants to merge 12 commits intomedihack:masterfrom
Conversation
Author
|
I also added |
Author
|
Any chance of this being merged? |
Author
|
Hey @medihack, do you think this have a chance of getting merged anytime soon? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I was trying to use the
.with_flag(reason)scope for Flagging, as it is documented inREADME, but I realized there's no scope for that in the code. I added itAlso, I fixed the spec
schema.rbto includeflaggings_countcolumn (all tests were failing before that).Hope you like to include this!
Regards,
PS: I also noticed generator spec is red in Rails >= 4.0, but I don't know how to fix that. You can have a peep here: https://travis-ci.org/dgilperez/make_flaggable/builds/35460558