Conversation
In the previous design of output(), you could get into a situation where the outputs for the test depended on which output path the test took, meaning that if an error occured, it would generate an error golden, but once the error was resolved, it would fail to delete the error golden. This change requires that all outputs be specified up-front.
Rust does not provide a way to specify that there are non-Rust files relevant to the build that should cause the build to stale if they change. We implement this ourselves through some gross mtime hacks. The best we can do is inform the user that inputs have changed and they must re-run cargo test to cause the tests to be rebuilt against the new inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.