Skip to content

ENG-3834: Clean up pom.xml#596

Merged
horgh merged 3 commits intomainfrom
greg/eng-3834
Feb 3, 2026
Merged

ENG-3834: Clean up pom.xml#596
horgh merged 3 commits intomainfrom
greg/eng-3834

Conversation

@oschwald
Copy link
Member

@oschwald oschwald commented Feb 2, 2026

Summary

  • Remove redundant <source> and <target> from maven-compiler-plugin (the <release> element is sufficient)
  • Remove unused maven-site-plugin declaration
  • Remove obsolete distributionManagement section (replaced by central-publishing-maven-plugin)

Test plan

  • mvn clean test passes
  • mvn javadoc:javadoc passes

🤖 Generated with Claude Code

oschwald and others added 3 commits February 2, 2026 13:27
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the 'pom.xml' file by removing outdated, redundant, and unused configurations. The changes aim to streamline the project's build definition, making it more concise and easier to maintain, without impacting the build process or project functionality. It ensures the configuration aligns with current best practices for Maven projects.

Highlights

  • Maven Compiler Plugin Configuration: Removed redundant '' and '' elements from the maven-compiler-plugin configuration, as the '' element is sufficient for specifying the Java version.
  • Unused Plugin Removal: Deleted the declaration for the 'maven-site-plugin' which was no longer in use.
  • Obsolete Distribution Management: Removed the 'distributionManagement' section, as its functionality has been replaced by the 'central-publishing-maven-plugin'.
Changelog
  • pom.xml
    • Removed the 'maven-site-plugin' declaration from the build plugins section.
    • Eliminated the '' and '' tags within the 'maven-compiler-plugin' configuration, relying solely on the '' tag.
    • Deleted the entire 'distributionManagement' section, which was no longer necessary due to the adoption of 'central-publishing-maven-plugin'.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides some excellent cleanup for the pom.xml file. It correctly removes redundant or obsolete configuration, which improves the overall maintainability of the build definition. The changes are well-described and justified. Specifically:

  • The redundant <source> and <target> elements are removed from the maven-compiler-plugin, correctly relying on the <release> element which is the modern best practice.
  • The unused maven-site-plugin declaration is removed.
  • The obsolete distributionManagement section is removed, as this functionality is now handled by the central-publishing-maven-plugin.

These changes are all positive improvements. The pull request is well-executed.

@horgh horgh merged commit d1a7313 into main Feb 3, 2026
35 of 75 checks passed
@horgh horgh deleted the greg/eng-3834 branch February 3, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants