Upgrade Faraday to v2 & drop faraday_middleware#41
Open
stympy wants to merge 1 commit intomaximadeka:masterfrom
Open
Upgrade Faraday to v2 & drop faraday_middleware#41stympy wants to merge 1 commit intomaximadeka:masterfrom
stympy wants to merge 1 commit intomaximadeka:masterfrom
Conversation
faraday_middleware was absorbed into Faraday core in v2, so `f.response :json` continues to work without the extra gem. - Bump faraday dependency from ~> 1.0 to >= 2.0 - Remove faraday_middleware runtime dependency - Remove `require "faraday_middleware"` from connection.rb - Move `f.adapter :net_http` to end of Faraday block (required by v2) - Upgrade webmock ~> 3.0 (v2 lacks write_timeout support needed by Faraday 2) - Add base64 gem (removed from Ruby 3.4 default gems, needed by webmock) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a faraday upgrade yesterday, and this was one of my dependencies that needed to be updated. I did a bit of analysis with a tool I just built, and I found that several forks of this repo have independently fixed the faraday dependency. I had Claude put together this PR based on that research.
This fixes #38
faraday_middleware was absorbed into Faraday core in v2, so
f.response :jsoncontinues to work without the extra gem.require "faraday_middleware"from connection.rbf.adapter :net_httpto end of Faraday block (required by v2)