Add support for reviewer changes in merge requests#68
Open
lordievader wants to merge 1 commit intomaubot:masterfrom
Open
Add support for reviewer changes in merge requests#68lordievader wants to merge 1 commit intomaubot:masterfrom
lordievader wants to merge 1 commit intomaubot:masterfrom
Conversation
tulir
reviewed
Oct 6, 2023
templates/messages/issue_update.html
Outdated
| {{ assignee_changes(changes.assignees.added, changes.assignees.removed) }} | ||
| {{ issue_or_merge_link(object_attributes) }} | ||
| {% elif changes.reviewers %} | ||
| {{ assignee_changes(changes.reviewers.added, changes.reviewers.removed) }} |
Member
There was a problem hiding this comment.
This should have a new macro, requesting a review and assigning are different things
Author
There was a problem hiding this comment.
Added a reviewers_changes macro.
The merge request event webhook is called for reviwers updates, however this is ignored by the GitlabChanges class. Therefore these updates are not forwarded to Matrix. By adding the reviewers section to both the GitlabChanges and to the issue_update template (which is used for merge request updates) the bot reports about changes in reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge request event webhook is called for reviwers updates, however this is ignored by the GitlabChanges class. Therefore these updates are not forwarded to Matrix. By adding the reviewers section to both the GitlabChanges and to the issue_update template (which is used for merge request updates) the bot reports about changes in reviewers.