MLE-23744 implement optic fromDocs in node client#1049
Conversation
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
103b445 to
e0da9e3
Compare
a671f30 to
f3f1984
Compare
Add tweaked auto-generated functions and classes for optic fromDocs plan builder. Modify PlanColumnBuilder by adding PlanColumnBuilderBase to allow chaining during column definitions. This follows the patch builder pattern. Move transitiveClosure function after annTopK to match auto-generated code and make diff easier.
f3f1984 to
7cdc2ce
Compare
|
One pattern breaker: I added "types.Node" as a new additional param type for the vector() function. This matches other functions like op.xs.decimal in that they can accept an xpath result node. This supports an optic pattern like this that seems vital for the node client within fromDocs: |
rjrudin
left a comment
There was a problem hiding this comment.
Ran the tests locally on the latest nightly build, looks good! The tests do a great job of documenting the feature.
Add tweaked auto-generated functions and classes for optic fromDocs plan builder. Modify PlanColumnBuilder by adding PlanColumnBuilderBase to allow chaining during column definitions. This follows the patch builder pattern. Move transitiveClosure function after annTopK to match auto-generated code and make diff easier.