Skip to content

Claude/fix board layout rows k ek72#758

Merged
marcodejongh merged 2 commits intomainfrom
claude/fix-board-layout-rows-kEK72
Feb 8, 2026
Merged

Claude/fix board layout rows k ek72#758
marcodejongh merged 2 commits intomainfrom
claude/fix-board-layout-rows-kEK72

Conversation

@marcodejongh
Copy link
Owner

No description provided.

When centered, the V grade floats to the left edge and the tick button
to the right edge via absolute positioning, while the title and info
text are truly centered in the container. Non-centered layout unchanged.

https://claude.ai/code/session_011w4GqHuJm1jV97TP7FqRqS
@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Feb 8, 2026 0:34am

Request Review

@claude
Copy link

claude bot commented Feb 8, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Minor Issues

  1. packages/web/app/components/climb-card/climb-title.tsx:191 - The gap is removed when centered is true, but absolutely positioned elements don't participate in flexbox layout anyway. The non-centered case loses the grade element entirely - it was moved from after the center content box to before it, but the original also had {largeGradeElement} after the center box which is now removed. This changes the visual order for non-centered layouts (grade now appears first instead of last).

  2. packages/web/app/components/climb-card/climb-title.tsx:194,221 - Using position: 'absolute' with left: 0 / right: 0 without explicit top positioning relies on default behavior. This works but could be more explicit with top: '50%', transform: 'translateY(-50%)' for guaranteed vertical centering if the container height varies.

  3. Missing test coverage - No tests added for the layout changes. The centered horizontal layout behavior change (repositioning of grade element and rightAddon) should ideally have visual regression or unit tests.

@marcodejongh marcodejongh merged commit 3b4161e into main Feb 8, 2026
4 of 6 checks passed
@marcodejongh marcodejongh deleted the claude/fix-board-layout-rows-kEK72 branch February 8, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants