Skip to content

Standardize all ascent icons to consistent subtle grey#692

Open
marcodejongh wants to merge 2 commits intomainfrom
claude/standardize-ascent-icons-Z7IR6
Open

Standardize all ascent icons to consistent subtle grey#692
marcodejongh wants to merge 2 commits intomainfrom
claude/standardize-ascent-icons-Z7IR6

Conversation

@marcodejongh
Copy link
Owner

Use neutral[400] (#9CA3AF) grey for all ascent status icons (success
and failure) across the app: AscentStatus, logbook view, logbook
section, activity feed tags, and tick button/action badges.

https://claude.ai/code/session_01Ub8h9ZesSBHynefXpW2SH4

Use neutral[400] (#9CA3AF) grey for all ascent status icons (success
and failure) across the app: AscentStatus, logbook view, logbook
section, activity feed tags, and tick button/action badges.

https://claude.ai/code/session_01Ub8h9ZesSBHynefXpW2SH4
@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Preview, Comment Feb 7, 2026 4:45am

Request Review

@claude
Copy link

claude bot commented Feb 7, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. Hardcoded color values: In logbook-view.tsx:44-47 and tick-button.tsx:54 and tick-action.tsx:93, the color #9CA3AF is hardcoded instead of using themeTokens.neutral[400] as done correctly in queue-list-item.tsx:71,81. This violates the project's design token guidelines in CLAUDE.md.

    Affected files:

    • packages/web/app/components/logbook/logbook-view.tsx - uses '#9CA3AF' inline
    • packages/web/app/components/logbook/tick-button.tsx - uses '#9CA3AF' inline
    • packages/web/app/components/climb-actions/actions/tick-action.tsx - uses '#9CA3AF' inline

    Recommended fix: Import themeTokens and use themeTokens.neutral[400] consistently across all files.

Use design tokens consistently instead of hardcoded color values
in logbook-view, tick-button, and tick-action components.

https://claude.ai/code/session_01Ub8h9ZesSBHynefXpW2SH4
@claude
Copy link

claude bot commented Feb 7, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. UX concern: Using the same grey color (neutral[400]) for both success and failure icons removes meaningful visual distinction. Users can no longer quickly differentiate between successful sends and failed attempts at a glance (logbook-view.tsx:45-47, queue-list-item.tsx:71,81).

  2. Unused variable removal inconsistency: hasSuccessfulAscent was removed from tick-action.tsx and tick-button.tsx, but it's still used meaningfully in queue-list-item.tsx to show different icons. This creates inconsistent behavior across components showing the same data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants