Correct geodetic scale denominator calculation #3979
Draft
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@copilot can you add a test for the modified method? |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect coordinate used in geodetic scale denominator computation so geodetic scale correction is applied at the intended map position.
Changes:
- Correct
minGeoXcomputation inScale.getGeodeticDenominatorto useposition.xinstead ofposition.y.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@sebr72 this is ready to be reviewed and merged |
sbrunner
added
backport 3.28
…pendent projections (#3982) Add a regression test for geodetic scale with CH2056 X-position dependence Co-authored-by: sbrunner <353872+sbrunner@users.noreply.github.com> Co-authored-by: Stéphane Brunner <stephane.brunner@camptocamp.com>
sbrunner
force-pushed
the
fix/correct-geodetic-scale-denominator-calculation
branch
from
4520fe6 to
2c1ae8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #3828 to be able to apply the copilot fixies