Open
Conversation
|
I think we don't need a separate Also we might want to renumber the IDs while we can and make it id 0? |
Member
Author
|
@joto the weird part is that some protobuf encoder/decoders will enforce this to a string encoding, this isn't an issue in C++ but in other cases it is an issue. I suppose we could work around this by writing custom protobuf writers in each language but I could see this being a gotcha. |
|
@flippmoke Makes sense. Doesn't cost us anything really, so that's fine. Still think we should fix order though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution to #142
/cc @joto @ericfischer