Attribute names and value are now written in UTF-8 if TextEncoder exists#26
Open
jeff-tenhave wants to merge 1 commit intomapbox:masterfrom
Open
Attribute names and value are now written in UTF-8 if TextEncoder exists#26jeff-tenhave wants to merge 1 commit intomapbox:masterfrom
jeff-tenhave wants to merge 1 commit intomapbox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although dbf does not officially support UTF-8, it is supported by Shapefile. Right now non-ASCII characters end up getting written to the dbf as garbage values. So instead we just write them in UTF-8, if TextEncoder is found. If not, then we revert to the previous behavior. I also increased the field name length to 11 bytes (it was 8 bytes), as that is what is supported in dbf. Note: I think this PR is trying to accomplish the same thing as this one, except that it uses node Buffer. @danswick