Fix getting rootViewController#286
Open
AlexanderStrup wants to merge 2 commits intolukasgit:masterfrom
Open
Conversation
MahendraN35
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created flutter module to use it as library in native app. I used your plugin to get contacts. But I had runtime error in native app when tried to register plugins
GeneratedPluginRegistrant.register(with: flutterEngine);I did it according Flutter Docs to interaction with my module. I tried add window variable to my AppDelegate but it didn't help.
iOS 13+ has new methods and classes for getting window. With my changes I got the rootViewController but I think the runtime error is bad practice anyway so just add an error message to log when rootViewController still nil.