feat: unify native map views into single LuggMapView host#26
Merged
Conversation
Replace separate LuggGoogleMapView and LuggAppleMapView Fabric components with a single LuggMapView that delegates to provider-specific content classes (GoogleMapProvider, AppleMapProvider) via MapProvider protocol. - Add unified LuggMapViewNativeComponent spec with provider prop - iOS: MapProvider/MapProviderDelegate protocol in core/ - iOS: GoogleMapProvider and AppleMapProvider content classes - iOS: LuggMapView host view selects provider based on prop - Android: GoogleMapProvider extracted to core/ - Android: LuggMapView as thin host delegating to provider - Remove old LuggGoogleMapView/LuggAppleMapView native components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace separate
LuggGoogleMapViewandLuggAppleMapViewFabric components with a singleLuggMapViewthat delegates to provider-specific content classes (GoogleMapProvider,AppleMapProvider) via a sharedMapProviderprotocol.Architecture
LuggMapView) — owns Fabric lifecycle (props, commands, child mounting, events)GoogleMapProvider,AppleMapProvider) — plain objects managing the actual map view insideLuggMapWrapperViewproviderprop; Android always uses GoogleChanges
LuggMapViewNativeComponentspec withproviderpropMapProvider/MapProviderDelegateprotocol inios/core/GoogleMapProviderandAppleMapProvidercontent classes inios/core/LuggMapViewhost view selects provider based on propGoogleMapProviderextracted tocore/LuggMapViewas thin host delegating to providerLuggGoogleMapView/LuggAppleMapViewnative componentsType of Change
Test Plan
Checklist