Fix rails deprecation warnings (use after_commit -> { })#92
Open
sergeykish wants to merge 2 commits intolostboy:masterfrom
sergeykish:master
Open
Fix rails deprecation warnings (use after_commit -> { })#92sergeykish wants to merge 2 commits intolostboy:masterfrom sergeykish:master
sergeykish wants to merge 2 commits intolostboy:masterfrom
sergeykish:master
Conversation
Author
|
@lostboy any problem with this pull request? |
Contributor
|
@sergeykish This repo seems really inactive. Any thoughts on mantaining your own version with Rails 5 deprecation cleanup, and 5.1 support? |
Owner
|
Hey guys, I've left this for so long, apologies for going awol. If people are still keen I can put some time to bringing the repo and gem up to speed. |
Contributor
|
@lostboy glad you're back. I've checked this in depth couple of months ago, and I've found one fork that has been mantained and updated to work with Rails 5: https://github.com/davidakachaos/workless_revived & It's working ok! I think you should talk to @davidakachaos to join efforts! Thanks for coming back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
That's part of the
rails 5deprecation warnings cleanup.It fixes
DEPRECATION WARNING: Passing string to define callback.Change is almost mechanical and I hope new lambda syntax is quite old already (
ruby 1.9).I've also noticed specs failure with
rspec 3, changed gemspec to userspec 2instead.