Use httpx instead of requests for async compatibility#114
Draft
YoussefHenna wants to merge 2 commits intologdna:masterfrom
Draft
Use httpx instead of requests for async compatibility#114YoussefHenna wants to merge 2 commits intologdna:masterfrom
httpx instead of requests for async compatibility#114YoussefHenna wants to merge 2 commits intologdna:masterfrom
Conversation
|
@YoussefHenna are you successfully using this PR with httpx in production? It might make sense to create a fork and continue working on it. What’s your take? |
Author
I have not used it in a while, but was working last I tested. Feel free to create a fork out of this code and try it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/logdna/python/issues
The project is outdated and as such I'm getting linting and installation errors, however I have been able to integrate this into my project successfully and can confirm it works with a FastAPI server. If someone is willing to fix up linting and poetry-related issues, this should be good to go.