Conversation
davidzhao
left a comment
There was a problem hiding this comment.
nice work! 🚀
It'd be great to add some CI test coverage.
how should we set up a test/coverage suite for this? should we run it against a (local? cloud?) livekit-server or mock the interface? mocking sounds more reasonable but the agents protocol is pretty vast and it'd take a while to map everything. without plugins it's all quite abstract, i don't know what i'd write tests for exactly |
Right.. let's discuss this later. I was thinking it could test job lifecycle against livekit OSS, but honestly I'm not sure if it belongs in this repo. For our other repos we have been including unit/integration tests within the repo, and end to end testing (including LK server/etc) in a separate repo. Let's merge as is and discuss later! |
|
note to self to save me some looking up later: Bun has built-in Jest-compatible test and coverage functionality via |
it compiles! and it seemingly connects to the server just fine.
however, my tests are only at the worker level (e.g. connects, sends heartbeats, exits okay)
i don't know how to test any real-world functionality without the plugins, despite the fact that i'm 100% sure that every sub-component does not work as expected (since i never tested any)
request for comments, tests, nits, lints, etc