Open
Conversation
Improve naming clarity for module-level ContextVar variables: - var_root -> ctx_root - var_parent -> ctx_parent - var_self -> ctx_self - var_finding -> ctx_finding Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
Replace if-elif chain with COMPARISON_OPERATORS dict for better readability and extensibility. Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- Use 'raise SystemExit() from exc' to preserve exception chain - Add try-except for file reading and JSON parsing errors - Provide more descriptive error messages Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- Use 'or' operator to reduce redundant if statements - Replace assert with proper JSONPathFindError exception Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- Add _symbol and _operator class attributes to Compare base class - Move common _get_partial_expression and find to base class - Subclasses now only define _symbol and _operator attributes - And/Or retain custom find for short-circuit evaluation semantics Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- Array.__init__: use TypeError for invalid idx parameter - Predicate.__init__: use TypeError for invalid expr parameter - Brace.__init__: use TypeError for invalid expr parameter - Search.__init__: use TypeError for invalid expr parameter - Key.__init__: use TypeError for unexpected arguments - Contains.__init__: use TypeError for invalid parameters - Not.__init__: use TypeError for invalid parameters This ensures type checks work even with Python -O optimization. Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- get_begin: replace assert with RuntimeError - Array.find: simplify control flow, remove unreachable AssertionError - predicate: merge isinstance checks to remove assert - func_call: use FUNCTIONS dict mapping instead of if-elif chain Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
- Slice: rename self.end to self.stop to match parameter name - comparison_expr: use ValueError instead of AssertionError - doctest: update var_boo to ctx_boo for naming consistency Amp-Thread-ID: https://ampcode.com/threads/T-019c2e4e-7deb-7076-8168-36fbd8141afa Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes several refactoring improvements to enhance code quality and maintainability:
Main Changes
var_toctx_for better clarityFiles Changed
jsonpath/cli.py: Enhanced error handling with exception chainingjsonpath/core.py: Major refactoring of exception handling and ContextVar namingjsonpath/transformer.py: Simplified operator/function lookup with dict mappingstests/: Updated tests for bash portability and related changesAll changes are backward compatible and improve code readability and error messages.