[WIP] Migrate textsize, bracketcompletion and joinlines to C#694
Open
ItsZariep wants to merge 1 commit intolinuxmint:masterfrom
Open
[WIP] Migrate textsize, bracketcompletion and joinlines to C#694ItsZariep wants to merge 1 commit intolinuxmint:masterfrom
ItsZariep wants to merge 1 commit intolinuxmint:masterfrom
Conversation
migrate textsize, bracketcompletion and joinlines from Python to C because libpeas is kinda broken on Python
Member
|
libpeas has been ported to libgirepository-2.0 We are currently patching all the apps which were affected by the pygoject3 change. https://src.fedoraproject.org/rpms/libpeas1/c/247a876ce08dc8cc7f56111ffd7fc8a9acefd4a8?branch=f43 I also ported the changes required to xed https://src.fedoraproject.org/rpms/xed/blob/rawhide/f/libpeas_libgirepository2.patch Sadly meson still has a requirement on gobject-introspection-devel https://src.fedoraproject.org/rpms/xed/c/df79673c8b539ef13abdaf750ed6d7ad24c16069?branch=rawhide |
clefebvre
changed the title
Member
|
I'm wondering if it wouldn't be worth it actually migrating them to the core app directly. Some of these plugins provide really core app features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
textsize,bracketcompletionandjoinlinesplugins from Python to C.As described in #692, The Python loader is nonfunctional as of pygobject 3.52 because the latter was ported to libgirepository-2.0, which cannot be loaded together with libgirepository-1.0, which libpeas still depends on. resulting on xed effectively not loading plugins depending on Python.
Sadly, I was not able to properly port
open-uri-context-menu, so is not included in the PR.