Open
Conversation
Fix the debian community screenshots and remove own community + third party screenshots.
Also use the json api instead of scraping.
Remove not needed imports like bs4, gi{...} etc.
Double the allowed screenshots to now allow 8.
Signed-off-by: Allen <64094914+allendema@users.noreply.github.com>
Member
|
Author
|
When tested at the time, the given third-party url path had no screenshots for packages like mpv, vlc, etc. Four screenshots seems too little when one wants to view different aspects of an app, considering that they are community ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First party screenshots were too old.
Third party screenshots were not avaliable.
Debian - debshots scraping mechanism outdated.
Which only left the very old screenshot(s).
How
Fix the debian community screenshots and remove own community + third party screenshots.
Also use the json api instead of scraping.
Remove not needed imports like bs4, re, threading, gi{...}.
Double the allowed screenshots to now allow 8.