Conversation
301778e to
c16fb3f
Compare
e83a0ad to
c33b13d
Compare
|
Hi, the performance of even the initial search is a nice improvement but have you had a look at how the mintcommon installer library? The PkgInfo objects are already part of a cache... once you fetch the description ( I'd also rather add to the mintcommon classes instead of tacking on |
| summary=pkginfo.get_summary().upper(), | ||
| description=None | ||
| if not search_in_description | ||
| else self.installer.get_description(pkginfo, for_search=True).upper() |
There was a problem hiding this comment.
I had to really concentrate before this made sense.. can you make it something like:
description=None if not search_in_description
else self.installer.get_description(pkginfo, for_search=True).upper()
|
@mtwebster thank you for the review! I forgot all the details tbh, but your comments make sense to me. Maybe with the later additions search cache is not that useful, I'll need to take another look. (I didn't want to touch mintcommon/installer originally, partly because I don't know if it used anywhere else and if it's a good idea to add code only relevant to mintinstall there) |
installer.get_description()withfor_search=Truefor faster search (I'm not 100% sure what's the difference in terms of searching but it seems appropriate and the performance gain is very noticeable*)UPD:
simplescreenrecorder-2025-06-01_13.42.01.mp4
simplescreenrecorder-2025-06-01_13.27.04.mp4
--
*) 12s vs 200s on my machine