meson: allow installing systemd service without systemd#64
Open
JustSoup312 wants to merge 1 commit intolinux-speakup:masterfrom
Open
meson: allow installing systemd service without systemd#64JustSoup312 wants to merge 1 commit intolinux-speakup:masterfrom
JustSoup312 wants to merge 1 commit intolinux-speakup:masterfrom
Conversation
A vendor may support systemd while not installing it in the build environment. This would cause systemd to not be detected and the service to not be installed. Changes the logic to be based off of explicitly listing the option instead of automatically detected. Signed-off-by: Aster Boese <asterboese@mailbox.org>
Contributor
Eh? This looks like a bug in the build environment. We shouldn't be guessing where to install systemd units, and just use systemd-pkgconfig-provided information. |
Author
|
That isn't a bug in the build environment. Alpine Linux does not package systemd, but its downstream distribution postmarketOS does. Because postmarketOS uses the repositories from Alpine Linux, a compromise was made to package systemd units in Alpine's repositories for usage in postmarketOS. In practice, this means that at build-time, systemd doesn't exist. |
Contributor
|
Ew, ok. But then we should still try to get the path from pkgconfig when it is available, and only default to the prefix libdir when that fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vendor may support systemd while not installing it in the build environment. This would cause systemd to not be detected and the service to not be installed.
Changes the logic to be based off of explicitly listing the option instead of automatically detected.