Documentation: teaching: Review ARM lab#287
Open
razvand wants to merge 1 commit intolinux-kernel-labs:masterfrom
Open
Documentation: teaching: Review ARM lab#287razvand wants to merge 1 commit intolinux-kernel-labs:masterfrom
razvand wants to merge 1 commit intolinux-kernel-labs:masterfrom
Conversation
Review and improve contents. Do minor coding updates to skeleton. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Collaborator
sergiu121
reviewed
May 18, 2021
| -kernel arch/arm/boot/Image -nographic -dtb arch/arm/boot/dts/imx6ul-14x14-evk.dtb \ | ||
| -append "root=/dev/mmcblk0 rw console=ttymxc0 loglevel=8 earlycon printk" -sd tools/labs/core-image-minimal-qemuarm.ext4 | ||
|
|
||
| .. note:: LCDIF and ASRC devices are not well supported with ``Qemu``. Remove them from compilation. |
Member
There was a problem hiding this comment.
Explanation is two lines below.
sergiu121
reviewed
May 18, 2021
| 0209c000-0209ffff : 209c000.gpio gpio@209c000 | ||
| 021a0000-021a3fff : 21a0000.i2c i2c@21a0000 | ||
| 80000000-9fffffff : System RAM | ||
| $ cat /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_min_freq |
There was a problem hiding this comment.
That's not the file that we run cat on. It's /proc/iomem
Member
There was a problem hiding this comment.
Yes. @razvand can you fix this. Other than that it looks good to me.
tavip
reviewed
May 19, 2021
| └── var | ||
|
|
||
| As for ``x86`` we will make use of Yocto rootfs images. In order to download an ``ext4`` rootfs image for ``arm32`` one needs to run: | ||
| root@so2$ tree -d -L 2 |
Member
There was a problem hiding this comment.
There are a lot of whitespace code changes, are these intentional?
valighita
reviewed
May 19, 2021
| $ make -j8 | ||
| $ ./build/qemu-system-arm | ||
| $ git clone https://gitlab.com/qemu-project/qemu.git | ||
| $ ./configure --target-list=arm-softmmu --disable-docs |
There was a problem hiding this comment.
Maybe make it clear that this must be done from the qemu directory after cloning.
valighita
reviewed
May 19, 2021
|
|
||
| Use the ``4-hello/`` folder in the lab skeleton folder. | ||
|
|
||
| Implement a simple kernel module that prints a message at load/unload time. Compile it and load it on ``i.MX6UL`` emulated platform. |
There was a problem hiding this comment.
The module is already implemented. This might cause confusion.
valighita
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and improve contents. Do minor coding updates to skeleton.