tools: labs: qemu: add support for x86_64 host machines#286
Open
noureddine-taleb wants to merge 2 commits intolinux-kernel-labs:masterfrom
Open
tools: labs: qemu: add support for x86_64 host machines#286noureddine-taleb wants to merge 2 commits intolinux-kernel-labs:masterfrom
noureddine-taleb wants to merge 2 commits intolinux-kernel-labs:masterfrom
Conversation
Signed-off-by: Nour-eddine Taleb <contact@noureddine.xyz>
Collaborator
tavip
reviewed
May 17, 2021
Member
tavip
left a comment
tavip
left a comment
There was a problem hiding this comment.
This looks great, thank you for the patch. There is one tiny thing I would like you to change, please see bellow.
| TEMPDIR := $(shell mktemp -u) | ||
|
|
||
| $(KCONFIG): qemu/kernel_config.x86 | ||
| ifeq ($(ARCH),x86_64) |
Member
There was a problem hiding this comment.
This will change the source file, I think it is better to move this block after the copy below and update ^@
Author
There was a problem hiding this comment.
yeah, that's a great notice, I will fix it.
for x86_64 we add extra configs to kernel .config, after we copy the default config file, to avoid messing with default lab configs Signed-off-by: Nour-eddine Taleb <contact@noureddine.xyz>
tavip
approved these changes
May 18, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.