-
Notifications
You must be signed in to change notification settings - Fork 394
fix: [UIE-9258, 9488] - DBaaS Backup / delete dialog bugs #13355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: [UIE-9258, 9488] - DBaaS Backup / delete dialog bugs #13355
Conversation
| title={`Restore ${database.label}`} | ||
| > | ||
| {error ? ( | ||
| <Notice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved error notice to the top since that's our pattern
...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx
Outdated
Show resolved
Hide resolved
...ages/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/DatabaseBackupsDialog.tsx
Outdated
Show resolved
Hide resolved
| </Typography> | ||
| )} | ||
| {configs.map((config, index) => ( | ||
| {fields.map((config, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squeezing a small bug fix from #13350, no need for changeset since it hasn't been released yet.
Add a config option, then delete it by clicking x, you should not see undefined
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
Description 📝
Fix Database Cluster restore backups / delete dialog bugs
Changes 🔄
newest full backup plus incrementaloption if a first backup hasn't been completed yetScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Next release
Preview 📷
error.mov
delete.error.mov
How to test 🧪
Reproduction steps
Backups:
Restorebutton is enabled for theNewest full backup plus incrementaloptionDelete:
Verification steps
Backups:
Restorebutton is disabled for theNewest full backup plus incrementaloption with a tooltip explanationDatabaseBackups.tsxline ~318, remove the check forBoolean(unableToRestoreCopy)to enable the restore buttonDelete:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅