-
Notifications
You must be signed in to change notification settings - Fork 394
fix: [UIE-10093], [UIE-10139] - IAM Users Table: Fix pagination when the last user on a page is removed, UX copy updates #13352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@mpolotsk-akamai can you see if #13346 fixes your use case as well? |
@abailly-akamai but here is server-side pagination, and the table wasn’t updated after the data changed. So something is off with it |
@abailly-akamai , this change doesn’t fix my case. |
4f1310e to
a147f0a
Compare
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
|
@aaleksee-akamai @mpolotsk-akamai yes, sorry we are dealing with server side pagination. I find it surprising to have to do this. I wonder if this is always the case or if this is isolated with this particular case. Cause we would also want to try to fix it as the hook level if this is a general problem |
abailly-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works - perhaps we can work on a more holistic solution in the future. Those are still edge case so it's not a big priority to spend much time on it. thx!
| <Table aria-label="List of Users" sx={{ tableLayout: 'fixed' }}> | ||
| <UsersLandingTableHead order={order} /> | ||
| <UsersLandingTableHead | ||
| isChildWithDelegationEnabled={isChildWithDelegationEnabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I remember correctly, @abailly-akamai is not a big fan of passing down boolean props, and we had this discussion when I implemented that logic for this table
Description 📝
This PR fixes pagination in Users Table when the last user on a page is removed.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-02-02.at.11.54.09.AM.mov
Screen.Recording.2026-02-02.at.11.52.20.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
/iam/userswith 26 (or more) users.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅