-
Notifications
You must be signed in to change notification settings - Fork 394
upcoming: [UIE-9597] - IAM Parent/Child: Align proxy logic with delegate users #13336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18b43ce to
e90a275
Compare
| const [searchQuery, setSearchQuery] = React.useState<string>(''); | ||
| const { isIAMDelegationEnabled } = useIsIAMDelegationEnabled(); | ||
| const isProxyUser = userType === 'proxy'; | ||
| const isParentUserType = userType === 'parent'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we don't import these types from useDelegationRole?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cause userType is passed as a prop and didn't want to touch all the files it is implemented on, but it could indeed be done that way.
| const isProxyOrDelegateUser = Boolean( | ||
| user.user_type === 'proxy' || user.user_type === 'delegate' | ||
| ); | ||
| const showChildAccountAccessCol = profile?.user_type === 'parent'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: also can import from useDelegationRole
430e255 to
c07b80f
Compare
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Cloud Manager UI test results🎉 866 passing tests on test run #10 ↗︎
|
Description 📝
In the new model,
proxyusers (user_typefrom the/profileresponse) becomedelegateusers. When it comes to UI, it's pretty much a 1/1 relationship for Cloud Manager to provide the same experience.This PR takes a progressive, which is matching the proxy logic to delegates users, without deprecating proxy users since we will still server them for some time. (the concept of proxy users will be fully deprecated in a subsequent PR, once that change is made in APIv4).
Changes 🔄
'user_type" = 'proxy' OR 'user_type" = 'delegate')userTyperather thanuseroraccountin order to better align with APIv4 naming conventions and facilitate core reading logic comprehensionScope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
Verification steps
Legacy Parent/Child account
IAM Parent/Child account
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅