Skip to content

Conversation

@agorthi-akamai
Copy link
Contributor

@agorthi-akamai agorthi-akamai commented Jan 27, 2026

Description 📝

This PR adds a new test specification (spec) relating to deleting a notification channel in the Linode Manager application. It appears to be part of work on DI-29580, which is likely a ticket or issue identifier related to the notification channels feature.

Changes 🔄

Adds a test spec file to cover the "delete notification channel" functionality.
This may include UI test scripts (e.g., using Cypress or a similar tool) to automate the workflow of deleting a notification channel via the application interface.
The new specs likely ensure that notifications channels can be deleted successfully, and that UI and backend behaviors are as expected.

Target release date 🗓️Next Release

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

alert-notification-channel-list.spec.ts.12.mp4

How to test 🧪

pnpm cy:run -s "cypress/e2e/core/cloudpulse/alert-notification-channel-list.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

ui.actionMenuItem
.findByTitle('Delete')
.should('be.visible')
.should('be.disabled'); // ✅ key assertion for channels with alerts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agorthi-akamai ,let's remove emoji's from comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@agorthi-akamai
Copy link
Contributor Author

run_cypress

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 27, 2026
@bnussman-akamai bnussman-akamai changed the title test[DI-29580]:Add spec for delete notification channel test: [DI-29580]:Add spec for delete notification channel Jan 27, 2026
@bnussman-akamai bnussman-akamai changed the title test: [DI-29580]:Add spec for delete notification channel test: [DI-29580] - Add spec for delete notification channel Jan 27, 2026
@agorthi-akamai
Copy link
Contributor Author

@dmcintyr-akamai , please review and approve.

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Feb 3, 2026
@agorthi-akamai
Copy link
Contributor Author

@jdamore-linode : Requesting merge of this PR.The current test failures are unrelated to the changes

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing865 Passing11 Skipped37m 12s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@venkymano-akamai
Copy link
Contributor

approvals are there, jobs passed and cypress failure is unrelated

@venkymano-akamai venkymano-akamai merged commit f7ccd66 into linode:develop Feb 4, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Cloud Pulse Cypress Component Tests

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

6 participants