fix: [UIE-10094] Buckets query race condition #13319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
requested review from
bnussman-akamai,
cpathipa and
jdamore-linode
Contributor
Author
|
@cpathipa would appreciate your eyes on the logic since I remember you working on some of this |
bnussman-akamai
approved these changes
Jan 26, 2026
aaleksee-akamai
approved these changes
Feb 2, 2026
| ((isObjectStorageGen2Enabled && Boolean(endpoints)) || | ||
| (isObjMultiClusterEnabled && Boolean(regions)) || | ||
| Boolean(clusters)); | ||
| (isObjMultiClusterEnabled && |
Contributor
There was a problem hiding this comment.
I see that's working so it might be what was needed, but do we need all of that?
Contributor
Author
There was a problem hiding this comment.
Yes.. this is the fix and because the logic is a bit complex we need these conditionals to be more more fine grained. Not that I like it, but that's what I came up with, without bigger refactors. Happy yo consider a better solution if you can think of one
Contributor
There was a problem hiding this comment.
hmm
I see that regions already handles the condition isObjMultiClusterEnabled && !isObjectStorageGen2Enabled
const regions =
isObjMultiClusterEnabled && !isObjectStorageGen2Enabled
? allRegions?.filter((r) => r.capabilities.includes('Object Storage'))
: undefined;
so maybe we can do smth like this:
const queryEnabled =
enabled &&
(
(isObjectStorageGen2Enabled && Boolean(endpoints)) ||
Boolean(regions) ||
(!isObjMultiClusterEnabled && !isObjectStorageGen2Enabled && Boolean(clusters))
);
what do you think?
Contributor
Author
There was a problem hiding this comment.
This works - it's cleaner I agree. I need to confirm this works well in all cases but this should do it
Contributor
Author
There was a problem hiding this comment.
I even simplified the logic and just await any of the query. this fixes it
skulpok-akamai
approved these changes
Feb 4, 2026
Collaborator
Cloud Manager UI test results🔺 28 failing tests on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts,cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts,cypress/e2e/core/objectStorageGen2/bucket-details-gen2.spec.ts,cypress/e2e/core/objectStorage/object-storage-errors.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/access-keys-multicluster.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/object-storage.smoke.spec.ts,cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts,cypress/e2e/core/objectStorageMulticluster/bucket-delete-multicluster.spec.ts,cypress/e2e/core/objectStorage/enable-object-storage.spec.ts" |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Oh boy this was not expected. Since not being familiar enough with this feature I will close this for now and let the storage team find a more holistic refactor including a much needed cleanup - sorry @skulpok-akamai - i tried :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Customers have reported that upon loading Cloud Manager and navigating to the Object Storage page, Cloud Manager shows them the empty state landing page leading the customers to believe that all of their buckets are gone. Upon refreshing the page, the buckets load and appear as expected.
While it is hard to reproduce with the scenario above, one way to detect the bug consistently is to access that page through Cloud Manager auth callback redirect URL by signing out and back in.
🐛 The issue: a race condition with the complex logic to enable the query with our feature flags.
🔧 The fix: await any of the data source
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-26.at.13.10.46.mov
Screen.Recording.2026-01-26.at.13.09.06.mov
How to test 🧪
Prerequisites
Any account with a bucket
Reproduction steps
See video "Before"
Verification steps
See video "After"
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅