Update ListenableFutureUtil.java with log message#352
Merged
mchen07 merged 5 commits intolinkedin:masterfrom Jul 28, 2025
Merged
Update ListenableFutureUtil.java with log message#352mchen07 merged 5 commits intolinkedin:masterfrom
mchen07 merged 5 commits intolinkedin:masterfrom
Conversation
mchen07
reviewed
Jun 17, 2025
...jects/parseq-guava-interop/src/main/java/com/linkedin/parseq/guava/ListenableFutureUtil.java
Outdated
Show resolved
Hide resolved
mchen07
approved these changes
Jun 26, 2025
Contributor
|
pending this pR #355 to merge to fix build issue. |
mchen07
approved these changes
Jul 14, 2025
Contributor
|
Could you rebase with master and see if the test can pass? |
Contributor
Author
|
Rebased with master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix .
The error message seems a little dubious
The function is accepting task of Type Future but logs message with the task of type GRPC