proto: Move main key versioning docs to KeyValue#40
Open
MaxFangX wants to merge 1 commit intolightningdevkit:mainfrom
Open
proto: Move main key versioning docs to KeyValue#40MaxFangX wants to merge 1 commit intolightningdevkit:mainfrom
KeyValue#40MaxFangX wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
I missed the possibility of opting out from key-level versioning since it was buried in the `PutObjectRequest` docs. Putting it in `KeyValue` is a bit more visible IMO. I still left behind a note "See `KeyValue.version` ..." in the `PutObjectRequest` docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed the possibility of opting out from key-level versioning since it was buried in the
PutObjectRequestdocs. Putting it inKeyValueis a bit more visible IMO. I still left behind a note "SeeKeyValue.version..." in thePutObjectRequestdocs where the primary key-level versioning docs were originally located.