Finish migration to tracking all payments by PaymentId#784
Draft
tnull wants to merge 2 commits intolightningdevkit:mainfrom
Draft
Finish migration to tracking all payments by PaymentId#784tnull wants to merge 2 commits intolightningdevkit:mainfrom
PaymentId#784tnull wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
The switch to tracking payments by ID happend with LDK Node v0.3.0, which is >1.5 years old by now. We can be pretty certain that nobody is upgrading from an older version to the upcoming v0.8. Here we hence make the `payment_id` fields in `Event` required which is a nice API simplification that will also be utilized in the next commit.
.. will require Payment metadata store
|
👋 Hi! This PR is now in draft status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298.
Since by now LDK added the capabilities for inbound payment ids, we can now lean on them and remove any legacy instances where we assumed
payment_idto be derived frompayment_hash.This is currently still blocked on us adding a payment metadata store as for the JIT case we need a place to store the
LSPFeeLimitsupon invoice creation (and with this PR, we stop creating payment store entries inBolt11Payment::receive*, but rather create new entries only when handlingPaymentClaimable, as we do for BOLT12).Draft until we can move forward here.