Implement CPFP fee bumping for unconfirmed transactions#638
Implement CPFP fee bumping for unconfirmed transactions#638Camillarhi wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 4th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 5th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 6th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 7th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 8th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 9th Reminder Hey @tnull! This PR has been waiting for your review. |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Makes sense, but I think we'll want #628 to go in first (which in turn probably now should be based on top of another PR utilizing the BDK WalletEvent) so that we have a good way to track any bumps (RBF or CPFP) across our API. Feel free to draft until then.
I’ll go ahead and draft a PR that adds the event-based sync logic to |
Add `Child-Pays-For-Parent` functionality to allow users to accelerate pending unconfirmed transactions by creating higher-fee child spends. This provides an alternative to Replace-by-Fee bumping when direct transaction replacement is not available or desired. - Creates new transactions spending from unconfirmed UTXOs with increased fees - Specifically designed for accelerating stuck unconfirmed transactions - Miners consider combined fees of parent and child transactions - Maintains payment tracking and wallet state consistency - Includes integration tests covering various CPFP scenarios - Provides clear error handling for unsuitable or confirmed UTXOs The feature is accessible via `bump_fee_cpfp(payment_id)` method.
Camillarhi
force-pushed
the
feat/tx-cpfp
branch
from
5c9976b to
f25b925
Compare
|
It seems there is some movement on the BDK side: bitcoindevkit/bdk_wallet#370 If that PR keeps moving, it might make sense to just wait for it instead of reinventing the wheel here? |
3 participants
Add
Child-Pays-For-Parentfunctionality to allow users to accelerate pending unconfirmed transactions by creating higher-fee child spends. This provides an alternative to Replace-by-Fee bumping when direct transaction replacement is not available or desired.The feature is accessible via
bump_fee_cpfp(payment_id)method.Fixes: #22