sauron: add cache and global fetch lock#775
Open
daywalker90 wants to merge 2 commits intolightningd:masterfrom
Open
sauron: add cache and global fetch lock#775daywalker90 wants to merge 2 commits intolightningd:masterfrom
daywalker90 wants to merge 2 commits intolightningd:masterfrom
Conversation
daywalker90
force-pushed
the
sauron-cache-fetch-lock
branch
from
a864ed0 to
0e83ded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to get the tests passing again i had to either mock the esplora responses or make the plugin and test framework respect esplora's rate limit.
I decided to do the latter and add a global file based cache to reduce requests for the same URL in the cache's TTL.
The global fetch lock is needed for the race condition of same URL requests that happen often during multiple CLN node startups.
Please let me know what you think.
I'm tagging some of the original sauron authors (looking at the commit history):
@darosior @Amperstrand @chrisguida @russnes @ca-ruz @iorch @sip-21