Fix Windows compilation errors in platform-specific code#21
Merged
Conversation
Co-authored-by: lijy91 <3889523+lijy91@users.noreply.github.com>
Co-authored-by: lijy91 <3889523+lijy91@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Windows compilation errors (only modify code under the sr/platform/windows directory)
Fix Windows compilation errors in platform-specific code
Sep 17, 2025
Copilot stopped work on behalf of
lijy91 due to an error
September 17, 2025 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several Windows compilation errors in the
src/platform/windowsdirectory that would prevent the library from building on Windows systems.Issues Fixed
PIMPL Implementation Inconsistencies
The Windows platform code had naming mismatches between header declarations and implementations:
WindowManagerheader declaredpimpl_but implementation usedimpl_WindowManagerImplinstead ofImplto match forward declarationConst Correctness Issues
Several
Windowclass getter methods were declared as non-const in the header but should be const since they don't modify object state:Missing Library Linking Directives
Windows platform files were missing required
#pragma comment(lib, ...)directives for:shell32.lib- Required forShell_NotifyIconand other tray icon APIsoleacc.lib- Required for accessibility manager functionsTechnical Details
The fixes ensure proper compilation on Windows by:
All changes are minimal and surgical, focusing only on compilation correctness without altering functionality or breaking existing working code.
Testing
The changes have been verified to maintain consistency across all Windows platform files and ensure proper header/implementation alignment.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.