resolve noop comparison warning

[xloem]

libbitcoin-protocol/src/zmq/certificate.cpp:82:42: warning: comparison is always true due to limited range of data type [-Wtype-limits]
     for (uint8_t attempt = 0; attempt <= max_uint8; attempt++)

attempt will wrap and the loop never terminates. It looks like that's fine rare behavior.

[evoskuil]

Thanks. It looks like the intended behavior was to terminate with an error after 256 failed attempts, not to loop indefinitely. That’s corrected by changing the condition to <. Unlimited attempts is probably ok, but probabilistic halting never feels right.

[thecodefactory]

I prefer the bounded option. Another option is to update the settings loader to not need the repeated generations (as specified in the comments).

[xloem]

Where are the settings deserialized?

[evoskuil]

Where are the settings deserialized?

https://github.com/libbitcoin/libbitcoin-system/blob/master/include/bitcoin/system/config/parser.hpp

[xloem]

Submission has been changed to the proposed solution; # situation addressed at boostorg/program_options#101 .