-
Notifications
You must be signed in to change notification settings - Fork 301
Add a couple APIs for SolutionUO use of nemesis files #4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
|
Job Coverage, step Generate coverage on 041425a wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
jwpeterson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a good reason why we didn't install the Nemesis_IO_Helper file, presumably it was just due to the fact that it (used to) include "ne_nemesisI.h". Was there some other reason @roystgnr? I also see that the ExodusII_IO_Helper header file is installed now... so I guess it would be more consistent if we treated them both similarly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you edit Makefile.in by hand? I was expecting to see some changes to the files that generate the Makefile.in, but I don't see any. See, for example, include/rebuild_libmesh_HEADERS.sh, where noinst_blacklist is defined.
https://github.com/libMesh/libmesh/wiki/Adding-or-removing-source-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. I ll redo it with a configure bootstrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok done!
|
Both of these failures look unrelated |
refs idaholab/moose#32288
these are fairly minor and exactly the same as ExodusII_IO