Skip to content

Conversation

@GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Feb 2, 2026

refs idaholab/moose#32288

these are fairly minor and exactly the same as ExodusII_IO

@moosebuild
Copy link

moosebuild commented Feb 2, 2026

Job Coverage, step Generate coverage on 041425a wanted to post the following:

Coverage

5dc1f0 #4384 041425
Total Total +/- New
Rate 65.31% 65.30% -0.01% 0.00%
Hits 77608 77602 -6 0
Misses 41220 41242 +22 16

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 0.00% is less than the suggested 90.0%

This comment will be updated on new commits.

Copy link
Member

@jwpeterson jwpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a good reason why we didn't install the Nemesis_IO_Helper file, presumably it was just due to the fact that it (used to) include "ne_nemesisI.h". Was there some other reason @roystgnr? I also see that the ExodusII_IO_Helper header file is installed now... so I guess it would be more consistent if we treated them both similarly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you edit Makefile.in by hand? I was expecting to see some changes to the files that generate the Makefile.in, but I don't see any. See, for example, include/rebuild_libmesh_HEADERS.sh, where noinst_blacklist is defined.

https://github.com/libMesh/libmesh/wiki/Adding-or-removing-source-files

Copy link
Contributor Author

@GiudGiud GiudGiud Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I ll redo it with a configure bootstrap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done!

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Feb 3, 2026

Both of these failures look unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants