Distributed mesh fixes #4381
Open
Distributed mesh fixes #4381
+211
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed a corner case for me, IIRC with unpacking of element sets where we had a non-remote neighbor link whose backlinks were fine but whose descendants' backlinks weren't.
|
Job Coverage, step Generate coverage on 1e91f65 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Member
Author
|
Test failures unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes upgrade what we try to provide when redistributing a
DistributedMesh(we're now worrying about subactive elements' neighbor links too, if only to make consistency more straightforward to assert later), and fixes a number of cases (though not all; the last wasn't easy to split out) where we were failing to properly make aremote_elemneighbor link into a link to a no-longer-remoteElem *This is another changeset split out of #3759, independent of the ones split out in #4380.